CLVM enhancements and fixes by Pearl1594 · Pull Request #12617 · apache/cloudstack

Pearl1594 · 2026-02-09T19:47:40Z

Description

This PR enhances the existing CLVM implementation which was based on the deprecated CLVM technology which was based on corosync/pacemaker. With RHEL 7 having reached EOL, CLVM seems to be broken. CLVM supports RAW volumes on LVM , where as CLVM_NG support QCOW2 on LVM.

Further details: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Modernized+CLVM%3A+Enhancements+and+CLVM_NG+support

NOTE: On testing - it was identified that incremental snapshots for clvm-ng do not work as expected. As of now it's been removed from scope. So, CLVM and CLVM_NG would only support full snapshots.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-02-09T20:01:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.68%. Comparing base (d3e1976) to head (df61d6f).
⚠️ Report is 15 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (d3e1976) and HEAD (df61d6f). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (d3e1976) HEAD (df61d6f)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #12617       +/-   ##
=============================================
- Coverage     17.90%    3.68%   -14.23%     
=============================================
  Files          5938      454     -5484     
  Lines        532864    38798   -494066     
  Branches      65192     7151    -58041     
=============================================
- Hits          95392     1428    -93964     
+ Misses       426793    37183   -389610     
+ Partials      10679      187    -10492

Flag	Coverage Δ
uitests	`3.67% <ø> (+<0.01%)`	⬆️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…of running vm

Pearl1594 · 2026-02-11T19:43:29Z

@blueorangutan package

blueorangutan · 2026-02-11T19:44:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-11T20:28:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16801

codecov · 2026-02-17T15:24:41Z

Codecov Report

❌ Patch coverage is 43.69427% with 1326 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.89%. Comparing base (6bc83a3) to head (5958b94).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...oud/hypervisor/kvm/storage/ClvmStorageAdaptor.java	38.10%	421 Missing and 16 partials ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	30.82%	100 Missing and 1 partial ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java	13.46%	90 Missing ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java	21.69%	81 Missing and 2 partials ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java	54.42%	59 Missing and 8 partials ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	28.57%	61 Missing and 4 partials ⚠️
...wrapper/LibvirtClvmLockTransferCommandWrapper.java	38.63%	48 Missing and 6 partials ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	16.39%	51 Missing ⚠️
...tack/storage/endpoint/DefaultEndPointSelector.java	56.63%	32 Missing and 17 partials ⚠️
...n/java/com/cloud/storage/clvm/ClvmPoolManager.java	77.10%	25 Missing and 24 partials ⚠️
... and 29 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12617      +/-   ##
============================================
+ Coverage     18.75%   18.89%   +0.13%     
- Complexity    17966    18212     +246     
============================================
  Files          6160     6170      +10     
  Lines        552578   554821    +2243     
  Branches      67348    67719     +371     
============================================
+ Hits         103660   104812    +1152     
- Misses       437512   438494     +982     
- Partials      11406    11515     +109

Flag	Coverage Δ
uitests	`3.53% <ø> (-0.01%)`	⬇️
unittests	`20.09% <43.69%> (+0.13%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594 · 2026-02-18T16:33:12Z

@blueorangutan package

blueorangutan · 2026-02-18T16:40:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T17:32:01Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16875

Pearl1594 · 2026-02-18T20:23:11Z

@blueorangutan package

blueorangutan · 2026-02-18T20:24:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T21:16:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16877

…ached volumes

…ures, change the clvm vols to exclusive on source from shared, and on success, change dest vol to exclusive only for cross-pool migration

Pearl1594 · 2026-06-10T02:26:25Z

@blueorangutan package

blueorangutan · 2026-06-10T02:28:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-10T03:20:16Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18209

Pearl1594 · 2026-06-10T03:28:10Z

@blueorangutan test

blueorangutan · 2026-06-10T03:30:05Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

…her cleanups

Pearl1594 · 2026-06-10T18:33:56Z

@blueorangutan package

blueorangutan · 2026-06-10T18:36:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-10T19:28:20Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18218

blueorangutan · 2026-06-10T19:57:01Z

[SF] Trillian test result (tid-16274)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56161 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12617-t16274-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

Pearl1594 · 2026-06-10T20:02:30Z

@blueorangutan package

blueorangutan · 2026-06-10T20:04:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-10T20:50:04Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18221

Pearl1594 · 2026-06-10T20:52:18Z

@blueorangutan test

blueorangutan · 2026-06-10T20:54:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-06-11T12:26:55Z

[SF] Trillian test result (tid-16284)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52854 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12617-t16284-kvm-ol8.zip
Smoke tests completed. 149 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_ping_in_ssvm_success	`Failure`	15.53	test_diagnostics.py
test_05_ping_in_cpvm_success	`Failure`	15.53	test_diagnostics.py
test_isolate_network_password_server	`Failure`	12.93	test_password_server.py

Pearl1594 · 2026-06-11T21:21:00Z

@blueorangutan package

blueorangutan · 2026-06-11T21:22:05Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2026-06-11T22:20:27Z

Quality Gate failed

Failed conditions
1 Security Hotspot
33.6% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

blueorangutan · 2026-06-11T22:29:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18231

Pearl1594 · 2026-06-11T22:30:54Z

@blueorangutan test

blueorangutan · 2026-06-11T22:32:03Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

boring-cyborg Bot added component:kvm component:storage labels Feb 9, 2026

CLVM enhancements and fixes

9e03f4b

Pearl1594 force-pushed the clvm-enhancements branch from 5fc1f12 to 9e03f4b Compare February 9, 2026 21:39

Pearl1594 added 2 commits February 10, 2026 19:48

add support for proper cleanup of snapshots and prevent vol snapshot …

96edadc

…of running vm

remove snap vol restriction for sunning vms

f9d8062

harikrishna-patnala added this to the 4.23.0 milestone Feb 17, 2026

weizhouapache reviewed Feb 17, 2026

View reviewed changes

Comment thread ...apshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java

Pearl1594 force-pushed the clvm-enhancements branch from a08e7a5 to df61d6f Compare February 17, 2026 15:04

refactor clvm code

43e9384

Pearl1594 force-pushed the clvm-enhancements branch from df61d6f to 43e9384 Compare February 17, 2026 15:16

boring-cyborg Bot added component:api component:compute component:orchestration labels Feb 17, 2026

add support for live migration

c9dd7ed

Pearl1594 force-pushed the clvm-enhancements branch from 3f900e8 to c9dd7ed Compare February 17, 2026 22:54

add support for migrating lvm lock

4984ee5

Pearl1594 added 2 commits February 19, 2026 15:42

clvm deletion called explicitly

190b201

made necessary changes to allow migration of lock and deletion of det…

8a7e48a

…ached volumes

minor improvement - when migrating vm with volumes, if there's a fail…

3d2a3ca

…ures, change the clvm vols to exclusive on source from shared, and on success, change dest vol to exclusive only for cross-pool migration

JoaoJandre reviewed Jun 10, 2026

View reviewed changes

cleanup unused code and tests for incremental snaps for clvmng and ot…

11e2b87

…her cleanups

winterhazel reviewed Jun 10, 2026

View reviewed changes

Comment thread server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java Outdated

Comment thread server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

revert

f438897

Pearl1594 force-pushed the clvm-enhancements branch from 2fb696a to f438897 Compare June 10, 2026 19:55

apache deleted a comment from blueorangutan Jun 10, 2026

optimization

5958b94

Pearl1594 force-pushed the clvm-enhancements branch from 56c7aeb to 5958b94 Compare June 11, 2026 21:15

Conversation

Pearl1594 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

Uh oh!

codecov Bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

Pearl1594 commented Jun 10, 2026

Uh oh!

blueorangutan commented Jun 10, 2026

Uh oh!

blueorangutan commented Jun 10, 2026

Uh oh!

Pearl1594 commented Jun 10, 2026

Uh oh!

blueorangutan commented Jun 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pearl1594 commented Jun 10, 2026

Uh oh!

blueorangutan commented Jun 10, 2026

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Jun 10, 2026

Uh oh!

blueorangutan commented Jun 10, 2026

Uh oh!

Pearl1594 commented Jun 10, 2026

Uh oh!

blueorangutan commented Jun 10, 2026

Uh oh!

blueorangutan commented Jun 10, 2026

Uh oh!

Pearl1594 commented Jun 10, 2026

Uh oh!

blueorangutan commented Jun 10, 2026

Uh oh!

blueorangutan commented Jun 11, 2026

Pearl1594 commented Feb 9, 2026 •

edited

Loading

codecov Bot commented Feb 9, 2026 •

edited

Loading

codecov Bot commented Feb 17, 2026 •

edited

Loading